[CLI] Publish library via NPM needs change in Header Search Paths

If you create a library with react-native new-library [...] and publish it via NPM you could get an error, like RCTViewManager.h file not found after installing via npm install. This error just occurs, if you put your files in an additional subfolder, like /libfor example:

index.js
lib/[filename].xcodeproj
lib/[filename].h
...

To solve the error you need to add the Header Search Path $(SRCROOT)/../../react-native/React to the library.

I don’t know if this is path should get added always automatically, since this filestructure is pretty common, or just mentioned in the docs.

[joshuapinter]

@Purii I wouldn’t disagree that the Headers Search Path causes every newcomer confusion. I think a blurb in the docs is warranted. I’ll toss it on my list and see if I can cobble something together that hints people in the right direction…

[Purii]

@joshuapinter I pulled back my PR #2315 for the reason I wrote above.

this is issue is more related to certain libraries than to react-native

Adding the headers search paths to support a library structure like /lib/ wouldn’t solve issues with a structure like /lib/src/ and so on. I am of the opinion, that this depends on the author of every lib. Maybe a mention in the docs?