question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

.flowconfig in 0.49.1 has a bug which prevents using flow

See original GitHub issue

Is this a bug report?

Yes

Have you read the Contributing Guidelines?

Yes

Environment

Environment: OS: macOS Sierra 10.12.6 Node: 8.0.0 Yarn: 1.1.0 npm: 5.0.3 Watchman: 4.9.0 Xcode: Xcode 9.0 Build version 9A235 Android Studio: 2.3 AI-162.4069837

Packages: (wanted => installed) react: 16.0.0-beta.5 => 16.0.0-beta.5 react-native: 0.49.1 => 0.49.1

Steps to Reproduce

checking the newly created project using flow 0.53.0 throws an error

  1. yarn add flow-bin@0.53.0
  2. run ./node_modules/.bin/flow

Expected Behavior

Showing no errors

I think one of suppress_comment in .flowconfig has a bug and unfortunately there is no simple way to debug it since it is regex and on top of that you need to escape it and it becomes full of nonsense. Is there any tools that we can use to do the conversion back and forth?

Actual Behavior

Error: node_modules/react-native/Libraries/Lists/ListView/ListViewDataSource.js:21
       v----------------------------------------------------------------------------
 21:   /* $FlowFixMe(>=0.53.0 site=react_native_fb) This comment suppresses an error
 22:    * found when Flow v0.53 was deployed. To see the error delete this comment
 23:    * and run Flow. */
        -----------------^ Error suppressing comment. Unused suppression

Error: node_modules/react-native/Libraries/Lists/ListView/ListViewDataSource.js:25
       v----------------------------------------------------------------------------
 25:   /* $FlowFixMe(>=0.53.0 site=react_native_fb) This comment suppresses an error
 26:    * found when Flow v0.53 was deployed. To see the error delete this comment
 27:    * and run Flow. */
        -----------------^ Error suppressing comment. Unused suppression

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Reactions:4
  • Comments:9 (7 by maintainers)

github_iconTop GitHub Comments

2reactions
idecommented, Oct 6, 2017

Thanks for the heads up, will cherry pick and release 0.49.2 later tonight.

1reaction
idecommented, Oct 7, 2017

Cherry-picked that commit into 0.49-stable and pushed 0.49.2 to CircleCI. If CI succeeds, it will publish 0.49.2 to npm. CircleCI build is here: https://circleci.com/gh/facebook/react-native/22180.

Read more comments on GitHub >

github_iconTop Results From Across the Web

.flowconfig [options] | Flow
This is meant as an escape hatch to suppress Flow in a file without having to delete all the Flow-specific syntax. The default...
Read more >
react native - Visual studio code error :-Failed to start flow Error
Hello I am a beginner in React-native and below is my flowconfig file's version and I get an error with ...
Read more >
react-flag-icon-css | Yarn - Package Manager
A simple React SVG country flags component: it works with Css Modules (default) or standard Css . NPM version NPM downloads license Build...
Read more >
Getting Started with React Native and Flow | by Nader Dabit
Flow will help you prevent bugs and allow for better code ... New React Native projects come with a pre configured .flowconfig file...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found