index.android.js and index.ios.js should be unified also in build.gradle and iOS build file

Is this a bug report?

Yes

Have you read the Contributing Guidelines?

Yes

Environment

Environment: OS: Windows 10 Node: 8.5.0 Yarn: 1.2.1 npm: 5.5.1 Watchman: Not Found Xcode: N/A Android Studio: Version 2.3.0.0 AI-162.4069837

Packages: (wanted => installed) react: 16.0.0-beta.5 => 16.0.0-beta.5 react-native: 0.49.5 => 0.49.5

Steps to Reproduce

(Write your steps here:)

1. react-native init
2. cd android && ./gradlew assembleRelease

Expected Behavior

Assemble release should go fine but…

Actual Behavior

I receive: Cannot find entry file index.android.js in any of the roots:

And this is because (in case of android) after the upgrade with react-native-git-upgrade, the build gradle file didn’t change and the entry file is specified as below:

 *   // the entry file for bundle generation
 *   entryFile: "index.android.js",

[fiznool]

I’ve found that you need both the changes to the build.gradle file and your MainApplication.java file for this to work, and it’s also important where you put these lines of code in the two files.

build.gradle

Put the following in your android/app/build.gradle file, above the line that contains apply from: "../../node_modules/react-native/react.gradle"

project.ext.react = [
    entryFile: "index.js"
]

Make sure you use the correct build.gradle file - you want the one inside the app folder.

MainApplication.java

Put the following in your MainApplication.java file, which will be located inside a subdirectory tree in the android/app/src folder:

@Override
protected String getJSMainModuleName() {
  return "index";
}

This needs to live inside the call to new ReactNativeHost(this). Here’s an example of how it appears in my workspace:

public class MainApplication extends Application implements ReactApplication {

  private final ReactNativeHost mReactNativeHost = new ReactNativeHost(this) {
    @Override
    public boolean getUseDeveloperSupport() {
      return BuildConfig.DEBUG;
    }

    @Override
    protected List<ReactPackage> getPackages() {
      return Arrays.<ReactPackage>asList(
          new MainReactPackage(),
            new VectorIconsPackage()
      );
    }

    @Override
    protected String getJSMainModuleName() {
      return "index";
    }
  };

  @Override
  public ReactNativeHost getReactNativeHost() {
    return mReactNativeHost;
  }

  @Override
  public void onCreate() {
    super.onCreate();
    SoLoader.init(this, /* native exopackage */ false);
  }
}

[Jp3rd]

add this code inside the method “mReactNativeHost” of the MainApplication.java file. This should work 😃 @giacomocerquone

@Override
 protected String getJSMainModuleName() {
        return "index";
 }

Can someone (from react native team) change this automatically when developers upgrade from older versions?