Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Make master to pass tests on CI

See original GitHub issue

Currently CI is broken due to flow failing. After investigating that matter for a bit, it turns out issues are coming from metro-bundler package.

It doesn’t happen on 0.49-stable and has been a result of either flow or metro-bundler being updated.

I am opening this issue to keep a better track of the status of this issue. Further more, I would also suggest to change the order of tests being run on the CI. I believe flow and eslint should run last, after unit tests. They often break or error temporarily and I’ve seen many PRs landing to the repo that break those two test suites. That, unfortunately, makes unit tests to never run and I am afraid some might ignore them for time being.

For reference: This issue is currently blocking release of 0.50-stable branch.

CC: @cpojer @hramos

Issue Analytics

State:
Created 6 years ago
Comments:7 (5 by maintainers)

Top GitHub Comments

5reactions

grabboucommented, Oct 11, 2017

Pull requests #16301, #16302, #16303, #16308 fix all failures and make master green again. As a proof, 0.50-stable is green and about to hit npm soon.

4reactions

grabboucommented, Oct 10, 2017

Good catch! I thought it got included in the last release. I have asked for updated release already and waiting for the update.