[NavigatorIOS] Implement hidesBottomBarWhenPushed to hide TabBar while doing push in native module

I followed the discussion on https://github.com/facebook/react-native/issues/720 and https://github.com/facebook/react-native/issues/1489, it seems the problem is not solved yet.

While it’s really easy to implement in Objective-C while setting viewController.hidesBottomBarWhenPushed = YES, I’m wondering if it’s possible to have it in native module.

// Objective-C
UIViewController *vc = [[UIViewController alloc] init];
vc.hidesBottomBarWhenPushed = YES;
[self.navigationController pushViewController:vc animated:YES];

// JavaScript
this.props.navigator.push({
    title: 'Detailed View',
    component: DetailedView,
    hidesBottomBarWhenPushed: true, // if possible
});

In the meanwhile, I was trying to modify RCTNavItem.m to pass additional attribute (hidesBottomBarWhenPushed) and RCTNavigator.m to inject code before the [_navigationController pushViewController:vc animated:(currentReactCount > 1)];

But it doesn’t work even though the attribute is correctly set before the pushViewController method, could anyone give me some insight about how to make it work?

[mcampsall]

I got it to work! See this SO answer for the code. I also posted it here if you want to see it in context

[mkonicek]

Hi there! This issue is being closed because it has been inactive for a while.

But don’t worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/navigatorios-implement-hidesbottombarwhenpushed-to-hide-tabbar-while-doing-push-in-native-module

Product Pains has been very useful in highlighting the top bugs and feature requests: https://productpains.com/product/react-native?tab=top

Also, if this issue is a bug, please consider sending a pull request with a fix.