onSubmitEditing event is firing twice on android

Issue Description

onSubmitEditing event is firing twice on android.

Steps to Reproduce / Code Snippets

Create the following code:

  _onChangeText(text) {
        this.setState({
            text
        });
    }

    _onSubmit(event) {
        this.props.onSubmit(this.state.text);
    }

<TextInput
                    ref='txtSearch'
                    maxLength={20}
                    returnKeyType='search'
                    placeholder={'Search here'}
                    underlineColorAndroid='rgba(0,0,0,0)'
                    onChangeText={text => this._onChangeText(text)}
                    onSubmitEditing={event => this._onSubmit(event)}></TextInput>

Then, tap on the field, type something and tap the search button on keyboard.

Expected Results

On iOS it works perfectly (the _onSubmit method is called only one time) but on Android it is calling two times.

Additional Information

• React Native version: 0.35.0
• Platform(s) (iOS, Android, or both?): Android
• Operating System (macOS, Linux, or Windows?): macOS

[rangav]

setting blurOnSubmit={false} worked for me on android

[reneweb]

The problem is that Android fires two EditorAction events when pressing the search button. It will fire one for the enter/submit action and another one for search action (https://github.com/facebook/react-native/blob/master/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputManager.java#L695). In Android these will have different id’s (actionId) and this can be used to filter only for the relevant events and therefore only handle the action once. However, it seems like we do not pass that information to the JS side, so there is no easy way to differentiate between these event types.

Generally I see two options to fix the issue:

• We pass the actionId to the JS side, such that the user can filter based on that. This would still leave it inconsistent to IOS and rather unintuitive, since there would still be two calls.
• We filter on the Android side and only fire enter action events from there, so we end up with only one event being fired. For this, we will need to make sure that this will work as desired in every case.

I will dig a little further into the second option, as this one would create a consistent experience, and see if that works, unless, of course, someone has a better idea how to fix it.