Platform is a read only object

Description

Seems like Platform object from react-native is a read only object, and mocking the functions like Version isn’t possible.

After doing Object.defineProperty(Platform, "Version", { writable: true }), I was able to update the object. Is this intentional?

Reproduction Steps and Sample Code

Example: Platform.Version = 24

Solution

Haven’t looked too deep into, but if it’s something that needs to change I’d like to do a PR for it

Additional Information

• React Native version: 0.40
• Platform: both

[hey99xx]

What about Platform.OS?

What about it? It’s not really different from Version.

mockablePlatform.mockInternal = (key, value) => mockablePlatform[key] = value;

if you really wanted it. What do you propose, a PR that freezes entire Platform object? I don’t see a standard in this code base that freezes the public APIs (for example all react-native keys are also writable), but then again I am not a contributor to this project so I’ll let FB engineers comment for it.

[hramos]

Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we’re automatically closing issues after a period of inactivity. Please do not take it personally!

If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:

• Does the issue still reproduce on the latest release candidate? Post a comment with the version you tested.
• If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
• Is there a pull request that addresses this issue? Post a comment with the PR number so we can follow up.

If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.