PropTypes from React package on 0.45.1 release builds failing

Release builds are failing for Android on the 0.45.1 release of React Native. I’ve only tested this on Android, but I suspect the same is true for iOS.

Lines such as var ReactPropTypes = require('React').PropTypes; in LayoutPropTypes.js (among several others) are causing this.

The result is a crash on startup with a js exception: com.facebook.react.common.JavascriptException: undefined is not an object (evaluating 'ReactPropTypes.shape'), stack:

I’m aware that this is fixed on the master branch. I thought I would report this issue still, as it effectively cripples the 0.45.1 release and I need to release against master to make our app release builds work.

@andrewimm I see you fixed these lines on master, maybe you know what is going on here?

[murat-mehmet]

for me running the following fixed it without additional clean:

npm install react@16.0.0-alpha.12

[bartolkaruza]

@stoffern @tuneZola Just to help clarify this discussion. The issue is not wrong usage of the prop-types package by implementers. If you have prop-types in your package.json, it does not resolve the issue. The issue is wrong usage of prop-types from the React package in the React Native Libraries;

Basically, there is a mismatch between the React package ^16.0.0-alpha.12 and the React Native package 0.45.1. This is the default combination if you upgrade your project to 0.45.1, causing the issue. In the React Native codebase, there are references to both React.createClass and to import {PropTypes} from 'react'; Just search for it in your node_modules/react-native/Libraries if you do not feel that this could be true.

You can work around this by either downgrading the react version to pre-16, but I don’t know what the potential impact is of that, I haven’t tried it. Or using the non-released React Native code from master, where the references to React.createClass and PropTypes} from 'react' are already removed, at your own risk. 😃