Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Releases] Update test-manual-e2e.sh to accept configurations for ios, android, hermes, jsc, etc.

See original GitHub issue

Roughly speaking, want to update this script to prompt someone like this:

$ ./scripts/test-manual-e2e.js
> What platform do you want to test?
   * Android
   * iOS
> What VM are you test?
   * Hermes
   * JSC

Please comment below if you have more questions – this issue isn’t super descriptive

Issue Analytics

State:
Created 2 years ago
Reactions:2
Comments:5 (3 by maintainers)

Top GitHub Comments

2reactions

lunaleapscommented, Jan 6, 2022

@vicente-s So this issue is about improving this file: https://github.com/facebook/react-native/blob/main/scripts/test-manual-e2e.sh

Which currently goes through a sequence of testing:

RNTester on iOS with JSC
RNTester on iOS with Hermes
RNTester on Android with JSC
RNTester on Android with Hermes
a new RN app using the template for iOS with JSC
A new RN app using the template for Android with JSC

The script goes through the sequence in that order and as you see it’s not testing the RN new app template with Hermes. This issue is about modifying test-manual-e2e.sh to allow a user to select which scenario to test rather than us having to run them all in order.

Additionally, it’d be great if we could add support for a new RN app for iOS/Android with Hermes as well but that can be a follow-up. Does that make sense? Is this something you’d be interested in?

It’d most likely be playing with yargs to modify the script

1reaction

vicente-scommented, Dec 26, 2021

Hoping I can take this issue 😬