[RN 0.49-rc.5] Fishhook error

Is this a bug report?

No.

I tried to manually upgrade from 0.48.3 to 0.49-rc.5 due to the BLOB_URL error that happens in sed version.

https://github.com/facebook/jest/issues/4433 https://github.com/facebook/react-native/issues/15810

When upgrading everything went well until the following error occurred:

I tried adding:

pod "React", :path => react_native_path, :subspecs => ['DevSupport', 'fishhook']

However this did nothing for me, there is currently no documentation on how to integrate fishhook when manually upgrading. Can anyone help?

Have you read the Contributing Guidelines?

Yes

Environment

Environment: OS: macOS Sierra 10.12.4 Node: 7.8.0 Yarn: 0.24.6 npm: 5.4.0 Xcode: Xcode 8.3.3 Build version 8E3004b

Packages: (installed) react-native: 0.49-rc.5 react: 16.0.0-alpha.12

Target Platform: iOS (10.3)

Expected Behavior

Build succeeds

Actual Behavior

Build fails because it cannot find fishhook files

[mobinni]

update I figured it out to be a mis-import in reconnecting websocket, it links to

#import "<fishhook/fishhook.h>"

while it should link to

#import "fishhook.h"

[iwasrobbed-ks]

@johannth You can add a postinstall script to fix that issue into your package.json like

"scripts": {
        "postinstall": "sed -i '' 's#<fishhook/fishhook.h>#\"fishhook.h\"#g' ./node_modules/react-native/Libraries/WebSocket/RCTReconnectingWebSocket.m",
        // any other scripts here
},