RN 0.70 puts 1.5G+ hermes binaries into ios/Pods

Description

After upgrading to 0.70 I’ve noticed that ios/Pods now includes huge hermes binaries in ios/Pods/hermes-engine/destroot/Library/Frameworks/universal/hermes.xcframework One is ~1GB, another is ~500MB. We store ios/Pods in VCS, so can’t afford to push huge binaries like these. Is this approach going to stay?

Version

0.70

Output of npx react-native info

System: OS: macOS 12.4 CPU: (12) x64 Intel® Core™ i7-9750H CPU @ 2.60GHz Memory: 185.20 MB / 16.00 GB Shell: 3.2.57 - /bin/bash Binaries: Node: 16.15.1 - /usr/local/bin/node Yarn: 1.22.19 - /usr/local/bin/yarn npm: 8.11.0 - /usr/local/bin/npm Watchman: 4.9.0 - /usr/local/bin/watchman Managers: CocoaPods: 1.11.3 - /Users/denyskniazhev/.rvm/gems/ruby-2.6.5/bin/pod SDKs: iOS SDK: Platforms: DriverKit 21.4, iOS 15.5, macOS 12.3, tvOS 15.4, watchOS 8.5 Android SDK: API Levels: 28, 30, 31 Build Tools: 28.0.2, 28.0.3, 29.0.2, 30.0.2, 30.0.3, 31.0.0, 33.0.0 System Images: android-30 | Google Play Intel x86 Atom, android-31 | Google APIs Intel x86 Atom_64 Android NDK: Not Found IDEs: Android Studio: 2021.2 AI-212.5712.43.2112.8815526 Xcode: 13.4.1/13F100 - /usr/bin/xcodebuild Languages: Java: 11.0.8 - /usr/bin/javac npmPackages: @react-native-community/cli: Not Found react: 18.1.0 => 18.1.0 react-native: 0.70.0 => 0.70.0 react-native-macos: Not Found npmGlobalPackages: react-native: Not Found

Steps to reproduce

Upgrade to 0.70 cd ios/ run pod install check files in ios/Pods/hermes-engine/destroot/Library/Frameworks/universal/hermes.xcframework

Snack, code example, screenshot, or link to a repository

see Steps to reproduce

[denisk20]

@iBotPeaches No, node_modules can be platform- or environment-dependent, while Pods contain source files which are always the same, thus it’s eligible for storing in VCS. In fact, this is what cocoapods docs recommend. I highly doubt that your node_modules is that big because of 1GB+ binaries inside.

[cortinico]

Any update?

There are no updates to be given here. That’s behaving as expected. We can update the docs if needed to make it clear for users that this is the intended behavior