RNTester Android instacrash on release mode

Description

While working on https://github.com/facebook/react-native/pull/33057 I noticed that RNTester Android release builds where instacrashing on release mode, at first I thought this had something to do with the AGP upgrade but even after switching to the main branch and cleaning cache the issue persisted.

https://user-images.githubusercontent.com/11707729/152910820-b097ce6a-8ed4-4c63-b973-211232906034.mov

I tested building the app through Android studio and by manually running

./gradlew :ReactAndroid:installArchives
./gradlew :packages:rn-tester:android:app:installHermesRelease 

Both resulted in the same problem.

From the logs this seems to be related to the androidx.appcompat:appcompat version we using, but I still haven’t tried upgrading it.

Version

0.68.0

Output of npx react-native info

System: OS: macOS 12.0.1 CPU: (8) arm64 Apple M1 Memory: 109.39 MB / 16.00 GB Shell: 5.8 - /bin/zsh Binaries: Node: 16.10.0 - ~/.volta/tools/image/node/16.10.0/bin/node Yarn: 1.22.11 - ~/.volta/tools/image/yarn/1.22.11/bin/yarn npm: 7.24.0 - ~/.volta/tools/image/node/16.10.0/bin/npm Watchman: 2021.09.27.00 - /opt/homebrew/bin/watchman Managers: CocoaPods: 1.11.2 - /opt/homebrew/bin/pod SDKs: iOS SDK: Platforms: DriverKit 21.2, iOS 15.2, macOS 12.1, tvOS 15.2, watchOS 8.3 Android SDK: Not Found IDEs: Android Studio: Not Found Xcode: 13.2.1/13C100 - /usr/bin/xcodebuild Languages: Java: 13.0.1 - /usr/bin/javac npmPackages: @react-native-community/cli: ^7.0.1 => 7.0.1 react: 17.0.2 => 17.0.2 react-native: Not Found react-native-macos: Not Found npmGlobalPackages: react-native: Not Found

Steps to reproduce

1. Open react-native repo on Android Studio
2. Select hermesRelease as the Active Build Variant
3. Build and install the app

Snack, code example, screenshot, or link to a repository

Full log here https://gist.github.com/gabrieldonadel/d98b8d504aab192fa4163443c584cc94

[cortinico]

That’s concerning. Thanks for spotting this.

Seems to be complaining about not finding libjscexecutor.so although I’m running a Hermes build

What I believe is happening is: RN Tester is built without react.gradle but using react-native-gradle-plugin (which is going to replace react.gradle). It seems like the logic to clean-up the .so files inside the plugin is failing to remove libjsc.so from the plugin:

https://github.com/facebook/react-native/blob/669cd0257cfa6a8a1d5c8d6c741786b1abd62b41/packages/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/TaskConfiguration.kt#L215-L251

We should look into what’s the content of the APK for the 4 build variants (debug/release/hermes/jsc) and verify that the included .so files are correct.

[peterchibunna]

with a new project on Apple M1

What do you mean “with a new project”? The issue is about RN Tester

When you create a new react-native project, the issue is there, RNTester or not. I said I am “watching” this issue.