Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Support for classList

See original GitHub issue

Do you want to request a feature or report a bug?

feature

What is the current behavior?

Only className exists right now.

What is the expected behavior?

I think adding classList property for DOM elements would be useful. As far as I understand React Fire will drop support for IE11 but even in IE11, you can add or remove classList from elements.

Another idea might be adding support for for array type for className (or future class, which will make more sense because array). If array is passed, classList will be used for DOM elements. Otherwise, className is used as usual in the real DOM side.

Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?

All versions. I hope this is added in React Fire.

Issue Analytics

State:
Created 5 years ago
Reactions:3
Comments:7 (4 by maintainers)

Top GitHub Comments

3reactions

GeKormcommented, Oct 11, 2018

Unless I’m misunderstanding, I think this is already handled perfectly by classnames (docs link) or classcat.

0reactions

gaearoncommented, Nov 1, 2018

Please submit an RFC for how it should work. It’s not obvious to me what the design is when you mix classList with className, and what components that pass names through (but add extra ones) should do.

https://github.com/reactjs/rfcs

Thanks!