Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
Two comments in lstm.py seem to be incorrect
See original GitHub issueThis issue is in the file lstm.py https://github.com/pytorch/fairseq/blob/master/fairseq/models/lstm.py
Seems to me that the comment # x: bsz x output_embed_dim in line 286 should be changed to # x: bsz x source_embed_dim because in Line 279 self.input_proj = Linear(input_embed_dim, source_embed_dim, bias=bias) the Linear layer converts input_embed_dim to source_embed_dim
If the comment on Line 286 is changed then it seems that the comment on Line 284 # source_hids: srclen x bsz x output_embed_dim should be changed to # source_hids: srclen x bsz x source_embed_dim
Question: Is output_embed_dim equal to source_embed_dim
Issue Analytics
- State:
- Created 4 years ago
- Comments:5 (5 by maintainers)
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
PR submitted.
Resolved with #1185. Thanks!