[Bug] MISSING for Object Conf cls argument

🐛 Bug

OmegaConf cls argument should not be a mandatory value if target is defined. Can we change this to be an optional value with None being the default?

** Stack trace/error message **

omegaconf.errors.MissingMandatoryValue: Missing mandatory value: scheduler.cls
        full_key: scheduler.cls
        reference_type=ObjectConf
        object_type=ObjectConf

System information

• Hydra Version : 1.0.0rc2
• Python version : 3.7.7

[omry]

@shagunsodhani , please clean this up. dunno why I missed it:

@dataclass
# This extends Dict[str, Any] to allow for the deprecated "class" field.
# Once support for class field removed this can stop extending Dict.
class ObjectConf(Dict[str, Any]):
    # class, class method or function name
    target: str = MISSING

    # parameters to pass to cls when calling it
    params: Any = field(default_factory=dict)

    # cls is deprecated, use target, cls will be removed in Hydra 1.1
    cls: str = MISSING

    # class is deprecated, use target, class will be removed in Hydra 1.1
    # (class is Python keyword and is only supported through DictConfig)
    # class: str = MISSING

You can completely remove everytging after params. just kill cls, this was introduced in Hydra 1.0 and it’s not yet released. I don’t mind breaking here.

[omry]

Yes. We keep this was as a deprecation. This is much cheaper and is not contaminating interfaces.