[Bug] utils.instantiate fails with dict kwarg inputs

🐛 Bug

utils.instantiate fails with dict kwarg inputs

To reproduce

Minimal Code/Config snippet to reproduce

Suppose I have a config group file

model:
  class: models.Net
  params:
    some: 0
    values: 1

Let’s say I want to pass in a dictionary to models.Net as follows: utils.instantiate(cfg.model, some_config_argument={'test': 'dict'})

Stack trace/error message

This will throw KeyError: 'Accessing unknown key in a struct : model.params.test'

from params.merge_with(OmegaConf.create(kwargs)) in the instantiate function.

Expected Behavior

Expected to succeed and pass in the dict kwarg to the class constructor

System information

• Hydra Version : 0.11.0
• Python version : 3.7.6
• Virtual environment type and version : Conda
• Operating system : OS X

[omry]

closing as fixed in master. feel free to join the chat if you have questions.

[omry]

1. Awesome that it works on master. if you can stick to master to give it some testing as it evolves please do. (generally all tests are passing in master).

2. If I am understanding your problem correctly, try something like:

config.yaml

defaults:
  - optimizer: adam

foobar:
  cls: FooBar
  params:
    opt_cfg: ???

optimizer/adam.yaml

foobar:
  params:
    opt_cfg:
      cls: torch.Adam
      params:
        alpha: 0.1
        beta: 0.99