question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[TODO Roundup] Improved cleanup on task failure

See original GitHub issue

Summary

In general, we should strive to fully clean up tasks when a run ends, either intentionally or unintentionally. Unfortunately, we aren’t always able to get everything, so it should be possible to assess whether the resources for a task run have been successfully resolved after a shutdown to be able to force a shutdown again.

One possible implementation would be to write some kind of info for “last live time” on TaskRuns, and then scrub can go through anything that isn’t in a final state then check against the last live time to see if we should be killing them.

Requirements

  • Implement a CrowdProvider.scrub() method that will be used to remove and delete any pending tasks that have been disconnected
  • grep '# TODO(102)' returns no results.

Issue Analytics

  • State:open
  • Created 3 years ago
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
pringshiacommented, Jan 27, 2021
0reactions
JackUrbcommented, Sep 20, 2021

Updating to reflect our priorities. I think clearer cleanup functionality is a shorter term requirement for Mephisto, and I’m deprioritizing active catastrophic failure recovery entirely.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Cleaning up SharePoint Framework build folders - Rencore
When building SharePoint Framework Client Side Web Parts you might want to clean up the SharePoint Framework build folders. What is the best...
Read more >
Why Roundup Ready Crops Have Lost their Allure
However, this strategy would periodically eliminate the Roundup Ready crop, too, making it not much better than using non-resistant crops.
Read more >
9 Tips for Containerizing Your Node.js Application - Docker
Let's first consider a simple todo list application. This is a basic React application with a Node.js backend and a MongoDB database.
Read more >
@ember-data/record-data | Yarn - Package Manager
#7350 [Chore]: convert adapters to class syntax; #7359 [CI]: bump failure asset size ... #6809 [BUGFIX] cleanup rollup warnings (#6809); #6808 [FIX] improve...
Read more >
Congress Must Pass the 'For the People Act'
And despite increased engagement by small campaign donors last year, ... Incomplete and error-laden voter lists create opportunities for ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found