[LINUX]Exception when downloading a map for live replay ends in a 404

A stack trace caught when trying to watch a live replay:

java.util.concurrent.CompletionException: java.lang.NullPointerException
	<snip>
	at java.base/java.lang.Thread.run(Thread.java:844)
Caused by: java.lang.NullPointerException
	at java.base/java.nio.file.Files.provider(Files.java:99)
	at java.base/java.nio.file.Files.isDirectory(Files.java:2220)
	at com.faforever.client.map.MapService.readMap(MapService.java:223)
	at com.faforever.client.map.MapService.addSkirmishMap(MapService.java:210)
	at com.faforever.client.map.MapService.lambda$downloadAndInstallMap$15(MapService.java:439)
	at com.github.nocatch.NoCatch.noCatch(NoCatch.java:49)
	at com.github.nocatch.NoCatch.noCatch(NoCatch.java:34)
	at com.faforever.client.map.MapService.lambda$downloadAndInstallMap$16(MapService.java:439)
	at java.base/java.util.concurrent.CompletableFuture$UniAccept.tryFire(CompletableFuture.java:714)
	... 22 more

From what I can tell, getPathForMap can return null, but it isn’t handled anywhere, so it eventually gets passed to isDirectory.

Looking deeper, I suppose that DownloadMapTask does not download the map correctly, and yet it throws no exception: Downloading map dualgap_fix_adaptive.v0007 from http://content.test.faforever.com/faf/vault/maps/dualgap_fix_adaptive.v0007.zip This address returns 404. I think that the DownloadMapTask should throw an IOException in that case, but I’m a bit lost in the task / future callback soup so I’m not sure. Either way, the null from getPathFromMap should be handled, and that I suppose is a separate issue.

[1-alex98]

new server new luck

[Wesmania]

IIRC many maps freely mix case between zips, directory names and filenames. Copious use of lowercasing should fix this.