Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

ZipBombException for valid maps

See original GitHub issue

Some map file downloads don’t work because of a ZipBombException.

According to https://github.com/FAForever/faf-java-api/issues/326, a ZipBombException occurs if the extracted file is more than 100x larger than the zip file. Unfortunately, this seems to be the case for some real maps.

To Reproduce Download an affected map from the vault, e.g. crazyrush.v0003. https://content.faforever.com/faf/vault/maps/crazyrush.v0003.zip (10KB; expands to 1.3MB)

OS Windows

Issue Analytics

State:
Created 4 years ago
Comments:7 (7 by maintainers)

Top GitHub Comments

1reaction

Brutus5000commented, Nov 23, 2019

@axel1200 No, we should adjust the parameters, so it fires not so early. The question is, what are the right ones. Maybe 20MB rather than 1MB?

0reactions

1-alex98commented, Dec 9, 2019

Nobody can upload these kind of maps any longer, but it only happens if ppl upload maps that are monotonic, those are incompatible with the map vault rules anyway. This is actually pretty funny because the ZIP BOMB check enforces the map vault rules as a side effect. The rule says use more than three textures