3.0.0 release

Can be labelled ready when all other issues on this milestone are closed.

• check integration package compatibility
  • AutoFixture.AutoFakeItEasy - @blairconrad
    • fails - can’t find IFakeOptionsBuilder<T> in the new FakeItEasy. This is no different than the case when using AutoFixture.AutoFakeItEasy against FakeItEasy 2.x. Fixing AutoFixture/AutoFixture#693 would resolve this, but AutoFixture currently suffers from interregnum, so there’s no reason to expect any change soon.
    • Related issue: https://github.com/AutoFixture/AutoFixture/issues/693
  • AutoFixture.AutoFakeItEasy2
    • no issues. :shipit:
  • Machine.Fakes.FakeItEasy - @adamralph
    • Raised https://github.com/machine/machine.fakes/issues/37
  • Autofac.Extras.FakeItEasy - @thomaslevesque
    • Currently restricted to FIE [2.0.0,3.0.0), so releasing 3.0.0 won’t break it.
    • One test fails when upgrading to FIE 3.0.0. It relies on the old behavior of DoesNothing() that caused the method to return null, but now it returns a dummy instead. AutoFake has an optional callsDoNothing parameter which causes all methods to be configured with DoesNothing() when the fake is created, but doing this on a new fake has no effect for most methods (exceptions: ToString, GetHashCode, Equals, properties), it just resets them to the default behavior. It would probably make sense to remove the callsDoNothing parameter.
    • Related issue: https://github.com/autofac/Autofac.Extras.FakeItEasy/issues/10
  • EntityFrameworkTesting.FakeItEasy - @blairconrad
    • Fails. IReturnValueConfiguration.ReturnsLazily signature changed. On the other hand, the package is restricted to >= 1.25.2 && < 2.0.0, so I don’t think we need to worry about it.
    • Related issue: https://github.com/scott-xu/EntityFramework.Testing/issues/17
• run code analysis in VS in Release mode and address violations (send a regular PR which must be merged before continuing)
• if necessary, change VERSION_SUFFIX in AppVeyor to appropriate “-beta123” or “” (for non-betas) value and initiate a build
• check build
• edit draft release in GitHub UI:
  • ensure completeness of release notes, including non-owner contributors, if any (move release notes forward from any pre-releases to the current release)
  • attach main nupkg and/or analyzer nupkg, whichever have content to release
  • publish the release
• push nupkgs to NuGet using the Deploy option in AppVeyor
• de-list pre-release or superseded buggy NuGet packages if present
• tweet, mentioning contributors and post link as comment here for easy retweeting 😉
• post tweet in Gitter
• post a link to the GitHub Release in each issue in this milestone, with thanks to contributors
• run rake next_version[new_version] to
  • create a pull request that changes the version in CommonAssemblyInfo.cs to the expected version (of form xx.yy.zz)
  • create a new draft GitHub Release
  • create a new milestone for the next release
  • create a new issue (like this one) for the next release, adding it to the new milestone
• close this milestone

[thomaslevesque]

The fact that you’re recompiling worries me. That will test for one kind of problem, but not all. Maybe I misunderstand what you’re doing, but consider AutoFixture/AutoFixture#693 (comment). Sometimes a recompile will work, but the underlying types have changed in a way that makes previously-compiled assemblies incompatible with the new ones. I think updating FakeItEasy and adding redirects is the better way to check.

Ah, yes, I was checking source compatibility, not binary compatibility.

AutoFac.Extras.FakeItEasy is restricted to FIE [2.0.0,3.0.0), so it won’t accidentally update to 3.0.0+. And anyway they intend to upgrade to FIE 3.0.0, so it will be recompiled.

[blairconrad]

@thomaslevesque said

I just checked Autofac.Extras.FakeItEasy. No build error, but one test fails due to #830

The fact that you’re recompiling worries me. That will test for one kind of problem, but not all. Maybe I misunderstand what you’re doing, but consider https://github.com/AutoFixture/AutoFixture/issues/693#issuecomment-244396725. Sometimes a recompile will work, but the underlying types have changed in a way that makes previously-compiled assemblies incompatible with the new ones. I think updating FakeItEasy and adding redirects is the better way to check.