Fakes that overrides Equals are not considered to be equal to themselves

Similar to #1630, I found an odd behavior and couldn’t find any info on it -

class MyClass {
    public override bool Equals(object o) { ... } // calls to base
    public override int GetHashCode() { ... } // calls to base
}
var myClass = A.Fake<MyClass>();
myClass.Should().Be(myClass); // this fails.

This seems odd to me as they are the same object. Can someone explain if it is the intended behavior or is it a bug? I know that CallsBaseMethods() can solve this problem, but it is annoying to call it on every fake I create.

[blairconrad]

I think the creation of #1777 resolves this issue, so I’m going to close it. Thanks for bringing the peculiar behaviour to our attention, @afifit! If I’m wrong, and you do have more to discuss here, we’d be happy to reopen the issue.

[thomaslevesque]

Hi @afifit,

@blairconrad and I discussed this further, and we came to the conclusion that the current behavior probably isn’t useful to anyone, so we’re going to change it (for Equals, but also for GetHashCode and ToString). I opened a new issue to track this (#1777).

Note that the fake still won’t have the overridden behavior (to get that behavior, use CallsBaseMethod as you’ve been doing), but at least a fake will be equal to itself.