Inconsistent use of the # sign in error messages

As you can see in the following example, the error message tries to be very natural in its language. This should also be applied to the 2nd number in the text #7.

Have it be “never”, “once”, “n times” like the first number.

Assertion failed for the following call:
    SomeMethodName()
  Expected to find it exactly 6 times but found it #7 times among the calls:
[...]

[blairconrad]

Which variant would you choose?

Good question! I’d been thinking about it. The switch is a little bit of work, but I think maybe

Expected to find it at least twice but found it {once/twice/n times} among the calls

I mean, “1 times” would read funny anyhow, so if you’re going to have to switch, why not match the language of our built-in convenience methods?

I would change the code here and add a switch for case A or just remove the # sign for B https://github.com/FakeItEasy/FakeItEasy/blob/master/src/FakeItEasy/Core/FakeAsserter.cs#L64

Sounds fantastic. Note that a number of tests will break when you do this, but for all the right reasons 😉.

[blairconrad]

This change has been released as part of FakeItEasy 4.4.0.

Thanks for your help with this, @mertsch. Look for your name in the release notes! 🏆