[feature request] coc-pyright does not take into account black errors

I struggled a bit with the problem described in #229 until I ran black --diff --quiet <thefile> outside of vim (but with the correct venv), and got an actual error message from black complaining about a typo in my pyproject.toml. The error wasn’t in coc-pyright, but it was still displaying “file formatted with black”, which was misleading enough that I committed and pushed non-formatted code 🙈

I would be nice if coc-pyright could check the exit code of black and show some sort of error message (either the one from black, or just a pointer to where to look for details) if something went wrong.

I’ll take the opportunity to say thanks for a really nice piece of software 🙌

What’s the output of :CocCommand pyright.version coc-pyright 1.1.166 with Pyright 1.1.167

What’s the output of :CocCommand workspace.showOutput Pyright not relevant here

[fannheyward]

I feel like it shouldn’t say “Formatted with black”, since it didn’t actually do it.

This has been fixed already and will in next release.

[laurentS]

Thanks for the super quick fix! Yes, the error message does turn up in showOutput. But somehow, I don’t really see much more than a flash of error in the message area in neovim. If I run :messages after saving my python file, I see this:

[coc.nvim] Formatting with black failed
[coc.nvim] Formatted with black
"src/cli/main.py" 183L, 5419C written

but the first 2 lines flash by so quickly that I can’t see them. Is there a way to keep the error message visible? I feel like it shouldn’t say “Formatted with black”, since it didn’t actually do it.