Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

move tests to corresponding structures?

See original GitHub issue

After #197 is merged we will have implementations of structures:

Identity
Maybe
Array
Compose

This might grove after adding more algebras in future.

Possibly solution is to completely remove test from FL, but in this case fantasy-id, fantasy-maybe … should be always up to date and if we have a PR to add some spec to FL, before we land it, PRs for fantasy-* should be opened, to ensure PR in FL is correct, then PR in FL could be merged and version bumped. After which PRs in fantasy-* could update FL and be merged as well.

Related discussion

Issue Analytics

State:
Created 7 years ago
Comments:9 (8 by maintainers)

Top GitHub Comments

4reactions

SimonRichardsoncommented, Oct 30, 2016

I don’t. Duplication is an evil in itself. I can’t fathom why we constantly have to duplicate libraries containers over and over again. The point of the spec included the libraries around it, they’re a standard for the spec and because people have decided to implement their own (and have worse implementations!!!), they’re neglected because of this. I went to rectify this…

Fantasyland has standard libraries with the spec and should have been promoted from the start (which I regret not doing!) and we should strive to do this…

3reactions

safarelicommented, Oct 30, 2016

For example someone opens PR to adds Foo spec to FL and adds laws/foo.js once it looks good and is ready to merge, then the author will also open PR for fl-id or fl-maybe and depend on her development branch of the FL PR temporarily, add tests, and after it’s passing then PR in FL could be merged and version bumped, after which the PR in fl-id or fl-maybe could be updated to use published version of FL and be merged. (we just need at least Id Maybe to be up to date with correct FL)

Yeah it’s sort of complicated but the way we are doing it is not any better.

Top Results From Across the Web

How to move tests into a separate file for binaries in Rust's ...

You can use the #[path] attribute to specify the location of the file corresponding to the module: #[cfg(test)] #[path = ".

Figure Skating Levels

Moves in the field is a basic skating skills progression. Each test level has several set patterns of turns, edges, spirals and steps...

2 Syntactic constituenthood - Penn Linguistics

The most basic test for syntactic constituenthood is the substitution test. The reasoning behind the test is simple. A constituent is any syntactic...

Unit Tests, How to Write Testable Code, and Why It Matters

In this article, I will show that unit testing itself is quite easy; the real problems that complicate unit testing, and introduce expensive...

Test Strategy

Correct versioning of components moved into the appropriate test environment. Testing environment is configured and ready. Exit Criteria.