question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Feature Idea: ship the TypeScript types for this project

See original GitHub issue

Issue Description

Currently the package.json for this repo gets modified when deploying to NPM.

In GitHub, it has a "types": "index.d.ts" entry, but in npm, it does not include this file.

Steps to Reproduce / Code Snippets

  1. Using npm/yarn, Install react-native-gifted-chat
  2. Diff package.json in node_modules with package.json on GitHub.
  3. Notice how the types line is gone, and no index.d.ts exists in the npm node_module.

Expected Results

It’d be great if TypeScript types were available in this node_module.

Additional Information

  • Nodejs version: 10.x | 9.x
  • React version: 16.3.x
  • React Native version: 0.55.x
  • react-native-gifted-chat version: 0.4.3
  • Platform(s) (iOS, Android, or both?): Both

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Reactions:5
  • Comments:8 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
fbarthocommented, Jun 4, 2018

@lucasbento: https://github.com/FaridSafi/react-native-gifted-chat/pull/877 I also made some fixes to the types, I’d love to help contribute more!

1reaction
lucasbentocommented, Jun 4, 2018

I believe it’s because there has been no release after https://github.com/FaridSafi/react-native-gifted-chat/commit/7232ac023e11068b4eb7ae1ed72e848914ddf786.

cc @xcarpentier, would you be able to release a new version? I’m looking forward for the types as well.

Read more comments on GitHub >

github_iconTop Results From Across the Web

TypeScript | IntelliJ IDEA Documentation - JetBrains
You can quickly navigate through your TypeScript project in the IntelliJ IDEA editor using different actions and popups. Go to declaration of a ......
Read more >
New Features in TypeScript You Didn't Know Exist
This new concept was shipped with TypeScript 3.0, it basically lets one TypeScript project to depend on another TypeScript project by ...
Read more >
Documentation - TypeScript 4.3
Separate Write Types on Properties. In JavaScript, it's pretty common for APIs to convert values that are passed in before storing them.
Read more >
TypeScript Types Explained – A Mental Model to Help You ...
One thing that I want to dig deep in this Constraints topic is immutability. In JavaScript and TypeScript, we have the idea of...
Read more >
TypeScript library tips: Rollup your types! | by Martin Hochel
To to leverage TypeScript to full extent, you definitely wanna ship type declaration files to your consumers, so no matter if they use ......
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found