Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Support dark mode for poweredBy image

See original GitHub issue

Thanks for this amazing library.

It would be awesome to support dark mode. The current poweredBy image only has black text. Thanks!

Issue Analytics

State:
Created 3 years ago
Reactions:1
Comments:13

Top GitHub Comments

4reactions

nandorojocommented, Dec 1, 2020

I view it more as a style customization than necessarily a dark mode feature itself. You might style the drop down to be dark, even if the rest of your app isn’t in dark mode. Because of this, I think it makes more sense as a prop that the user has control over.

Maybe it makes more sense to just let the poweredByText get styled directly in styles, following the API of other styles, since you proposed using Text alongside the logo anyway.

2reactions

aidanarnoldcommented, Dec 1, 2020

@bell-steven I think this could be done simply by adding a darkMode prop to use for toggling the image in _renderPoweredLogo. That doesn’t get into the fussiness of selecting the best option from all the images Google provides for this, but it would at least satisfy this request. I’m willing to submit a PR, if this sounds like a good solution.