Error on optional array of records

Code to reproduce:

from fastavro import writer, reader

schema = {
    "type": "record",
    "name": "test",
    "fields": [
        {"name": "name", "type": "string"},
        {"name": "address",
         "type": [
             "null",
             {"type": "array",
              "items": {
                  "type": "record",
                  "name": "whatever",
                  "fields": [
                      {"name": "street", "type": ["null", "string"]},
                      {"name": "zip", "type": ["null", "string"]}
                      ]
                  }
              }
            ]
         }
    ]
}

records = [
    {'name': 'name1', 'address': [{'street': '22st'}]},
    {'name': 'name2'}
]


with open('test.avro', 'wb') as f:
    writer(f, schema, records, codec='deflate')

with open('test.avro', 'rb') as f:
    print(list(reader(f)))

If I write record name2 only, no error and reader returns [{'name': 'name2', 'address': None}] However for name1 where address is passed (correctly, as a list), it errors out: ...(type <class 'list'>) do not match ['null', {'type': 'array', 'items': {'type': 'record'...

[yan-hic]

@scottbelden thank you very much for the quick turnaround, for this and the ISO date enh !

[scottbelden]

I have a PR that resolves this case (and passes all the other tests). I’m pretty sure there are still some aspects that need to be fleshed out with unions and nulls and default values, but I suppose we’ll get to those when the time comes.