Deserializing enum by using String argument @JsonCreator method fails in 2.11.0

I upgraded Jackson version from 2.10.1 to 2.11.0. After upgrading, deserializing enum by using a delegating method that is annotated @JsonCreator and has a single String argument, fails.

This is a sample code. In Jackson.version = 2.10.1, it will complete successfully. However, in Jackson.version = 2.11.0, it will fail by the following exception.

Exception in thread "main" com.fasterxml.jackson.databind.exc.ValueInstantiationException: Cannot construct instance of `sample.EnumDeserializeTest$FooEnum`, problem: argument type mismatch
 at [Source: (String)"1"; line: 1, column: 1]

package sample;

import java.io.IOException;

import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonValue;
import com.fasterxml.jackson.databind.ObjectMapper;

public class EnumDeserializeTest {

    public static void main(String[] args) throws IOException {
        ObjectMapper mapper = new ObjectMapper();
        String json = mapper.writeValueAsString(FooEnum.FOO);
        mapper.readValue(json, FooEnum.class);
    }

    enum FooEnum {
        FOO(1);

        private final Integer code;

        FooEnum(Integer code) {
            this.code = code;
        }

        @JsonValue
        public Integer getCode() {
            return code;
        }

        @JsonCreator
        static FooEnum of(String code) {
            return FOO;
        }
    }
}

Is this behavior what you expect?

[cowtowncoder]

@ta7uw It is unfortunate that code earlier somehow did work in this case – I am not quite sure why this is, I would have expected a runtime exception for mismatch. Oh, actually, I think I do know: code was assuming value is String, and using getText() or getValueAsText(), which in case of numeric value would have coerced quietly into String. This behavior prevented use of factory method that takes int or long value; which is I think why code was changed. Not sure if that could have been #2605, but I now thing I remember this change.

[cowtowncoder]

@ta7uw I think I can see the problem: your JSON has number 1, but of method expects String value – this is a mismatch. I am not sure how things appeared to be working before, but to work shouldn’t you rather have:

        @JsonCreator
        static FooType of(int code) {
            return FOO;
        }

I do think that exception message in this case is not clear on specific mismatch, bit it does make sense to me.

Or, if you do not care about incoming value, have nominal type be Object (which matches any incoming JSON value)?