Set Etag automatically for each request

We can provide etag parameter in initial config which is by default set to true. The behaviour will be to automatically set etag header on all successful requests. In fact current implementation is not standards compliant. If I do reply.etag(), it always generates new etag even for same payload. Ideally it should generate same for same payload.

Something like this should be good.

let etag = crypto
    .createHash('sha1')
    .update(payload)
    .digest('base64')
    .substring(0, 27);
  reply.etag(etag);

[adityapatadia]

I’m not going to look at Express or Koa. I don’t know those frameworks and have never used them. I implemented this plugin by reading the RFC, as is plainly stated in the opening of the README.

Nowhere in RFC it is stated that response should be cached for 3600000 ms. It was arbitrary number chosen. Basically as @StarpTech says, the cache should be removed and pure content based ETag should be implemented.

I also disagree with creating fork. This is not a third party plugin but a fastify organisation official plugin. If this remains broken like this, less tech savvy users will keep using this plugin and get wrong behaviour than expected.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.