Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

saveRequestFiles hangs for some fields

See original GitHub issue

🐛 Bug Report

I send a simple multipart request with just one file and consume them with req.saveRequestFiles(). For some files it works, but for some other files never resolves. It seems that the code hangs here https://github.com/fastify/fastify-multipart/blob/5ca152453fc08a36f0ccd943af9f574db52526e7/index.js#L502 after successfully processing the file.

To Reproduce

Steps to reproduce the behavior:

const files = await req.saveRequestFiles();

Expected behavior

Does not hang

Your Environment

node version: 14
fastify version: 3.5.1
os: Linux

Issue Analytics

State:
Created 3 years ago
Comments:11 (3 by maintainers)

Top GitHub Comments

1reaction

mcollinacommented, Nov 12, 2020

I think we can just workaround it in here by setting ._writableState.autoDestroy = false if it is true. @vkurchatkin could you make a PR to this repo?

1reaction

mcollinacommented, Nov 10, 2020

This looks a lot like a bug in pipeline 😦 and node core. Let me also ping @ronag who worked on that lately.

Would you be able to start peeling the onion and get to a reproducible case without the use of fastify or busboy?