question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

`verifyClient` isn't working and support should likely be removed

See original GitHub issue

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the bug has not already been reported

Fastify version

3.x.x

Plugin version

No response

Node.js version

unknown

Operating system

Linux

Operating system version (i.e. 20.04, 11.3, 10)

unknown

Description

When I tried using verifyClient in my server, Fastify kept sending Reply already sent errors. And in the ws documentation, it literally encourages not to use it. I believe this plugin should throw an error or deprecation warning when attempting to use verifyClient to avoid these issues in the future.

Steps to Reproduce

Start a Fastify server using this plugin with a verifyClient option and logging on.

Expected Behavior

I believe this plugin should throw an error or deprecation warning when attempting to use verifyClient to avoid these issues in the future.

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:7 (7 by maintainers)

github_iconTop GitHub Comments

1reaction
Eommcommented, Mar 7, 2022

And in the ws documentation, it literally encourages not to use it

I think it should be the ws module to emit the waning if they discourage its usage

0reactions
darkgl0wcommented, Mar 13, 2022

I will close this issue, verifyClient is working as it should and without a proper reproducible example we can not help you more than this.

Feel free to reopen if you are able to provide some code we can look at.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Pass verifyClient result to connection event #377 - GitHub
I would like to remove it completely. Now that verifyClient is the only reason, could async/sync behaviour depends on there is or not...
Read more >
stunnel won't verify client certificate as expected - Server Fault
This answer is not tested as I just start using stunnel, but from documentation I guess: a) you should drop the verify option, ......
Read more >
JWT Verify client-side? - node.js - Stack Overflow
So, you could check if a JWT has expired or not without verifying the signature, hence you don't need neither a public key...
Read more >
Fix unhealthy sensors in Microsoft Defender for Endpoint
Fix device sensors that are reporting as misconfigured or inactive so that the service receives data from the device.
Read more >
DeprecatedOptions – OpenVPN Community
This would not be possible with the old --client-cert-not-required option. Option: --ns-cert-type ¶. Status, Pending removal. Deprecated in: ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found