question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

skipIsVerifiedCheck doesn't call custom notifier.

See original GitHub issue

Steps to reproduce

When implementing auth management, I have set up email verification and reset password functionality. The problem I’m getting is when I’m trying to bypass the check for email verification when resetting the password.

Curently I’m setting it up like this:

app.configure(authentication).configure( authManagement({ skipIsVerifiedCheck: true, notifier: (type, user, notifierOptions) => notifier(type, user, notifierOptions), }) );

The whole code is very similar to this tutorial: https://hackernoon.com/setting-up-email-verification-in-feathersjs-ce764907e4f2 Except for minor details such as sendResetPwd and resetPwd filled out to include email subject and body and reset route which all work when user is verified.

And while the email verification works fine and sends the email to the client, when sending a post request to reset the password returns the response as if it has been reset, but no email has been sent as though the call didn’t go through. When checked in the database the user has been modified with exactly the same entry (password, email, etc.) so it bypassed my custom logic and just reset the password to itself it seems.

Tested it with console logs and it definitely doesn’t go through my notifier when using skipISVerifiedCheck option.

Expected behavior

Tell us what should happen

When POST request has been received the service should skip checking the verification field and call my notifier with “sendResetPwd” action.

Actual behavior

Tell us what happens instead

When POST request has been received the service skips checking the verification field but doesn’t call my notifier with the action.

System configuration

Tell us about the applicable parts of your setup.

Module versions (especially the part that’s not working):

“feathers-authentication-management”: “^3.1.0”, “@feathersjs/feathers”: “^4.5.12”,

NodeJS version:

Operating System:

Win11

Browser Version:

React Native Version:

Module Loader:

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:8

github_iconTop GitHub Comments

1reaction
MartynasRafcommented, Feb 3, 2022

That was it! Somehow I didn’t notice that, thanks for taking your time to investigate.

1reaction
claustrescommented, Jan 28, 2022

Just reading the code I don’t understand how it can actually work. Here you import your notifier but the export does not seem to be the notifier function, the export should be this to match the expected signature doesn’t it ?

Or you should probably use something like notifier(app).notifier here.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Configure Okta Verify options
To unblock affected users, set User verification to Preferred, and then advise end users to skip the biometrics enablement step. Push notification: Number ......
Read more >
Configure Azure AD Multi-Factor Authentication settings
The user views the notification and selects Verify to complete verification. The Microsoft Authenticator app is available for Windows Phone, ...
Read more >
Resolve issues receiving SNS notifications for CloudWatch ...
To determine why you're not receiving SNS notifications, check the history of the CloudWatch alarm to find the status of the trigger action....
Read more >
Verification, Updates, and Corrections - FSA Partner Connect
Number in college. V4—Custom Verification Group. Students must verify high school completion status and identity/statement of educational purpose (SEP) ...
Read more >
If Mail on your Mac can't verify a server's certificate
If a Mail server uses an SSL certificate that's signed by an unknown authority (such as a self-signed certificate), the Mail app on...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found