disable hook seems to have wrong true/false logic

Code here means to disable when the result is false, not to disable when the result is true.

if (typeof realm === 'function') {
    return function (hook) {
      const result = realm(hook);
      const update = check => {
        if (!check) {
          throw new errors.MethodNotAllowed(`Calling '${hook.method}' not allowed. (disable)`);
        }
      };
  }

But in docs here it seems to be opposite logic:

  // Disable the remove hook if the user is not an admin
  remove: hooks.disable(function(hook) {
    return !hook.params.user.isAdmin
  })

Either the doc or the code is wrong. I guest it’s the code which is wrong.

[eddyystop]

https://github.com/feathersjs/feathers-hooks-common/pull/108

The disableMethod hook deprecates disable in feathers-hooks-common v3.

[eddyystop]

I suggest we create another hook that works like disable but with the correct sense. We can wean people away from disable by stressing the new hook in docs and maybe adding a deprecated message.

Any suggestions for the name of the replacement hook?

p.s. I’ve suggested something similar be done with the remove hook which is a no-op for calls made by the server. I’ve suggested delete as the name of that replacement hook.