Incorrect behavior in a shard cluster

Currently .remove method always uses findAndModify. It should use deleteOne if ctx.id is present.

Main problem right now it’s not possible to remove document by _id without passing shard key, because .remove uses findAndModify, if it would use deleteOne you’ll be able to remove document just by _id, without passing extra query with sharding key.

This is my current workaround, in before remove hook:

if (
    ctx.id
    && ctx.service
    && ctx.service.Model
  ) {
    await ctx.service.Model.deleteOne({ ...(ctx.params.query || {}), _id: ctx.id });
    ctx.result = { _id: ctx.id };
  }

[marshallswain]

This makes complete sense to me. I completely agree about not having to pass a shard key. The only thing that could make that API worse is having to pass your social security number. 😉

It seems reasonable to me to have deleteOne become the default behavior. We could also go the route of supporting both and having an option to do one or the other. I don’t really feel like it’s necessary, though. Care to make a PR?

[sarkistlt]

@marshallswain yes, thank you!