Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Typo at FeathersVuexFind

See original GitHub issue

https://github.com/feathersjs-ecosystem/feathers-vuex/blob/master/src/FeathersVuexFind.ts#L81

It should be check for params, not for query.

Issue Analytics

State:
Created 3 years ago
Comments:6 (4 by maintainers)

Top GitHub Comments

1reaction

fratzingercommented, Sep 6, 2020

@shabanovd is right. Good catch! Before feathers-vuex@3.12.0 FeathersVuexFind only worked with :query="...". Now it also supports :params="{}" This is a leftover from #521 .

@J3m5 I think the philosophy of feathers-vuex is to always provide at least an empty query to prevent accidentally complete requests. From time to time it annoys me but I think over all it’s more helpful.

Should be fixed in #529

0reactions

J3m5commented, Sep 11, 2020

It appears that it has the same behavior than the makeFindMixin and the useFind hook. It is consistent so it’s not such a big deal. I think that it should be left as is for now and ask what others think about it. The only use case I see is if you want to explicitly not return the items but it can be achieved by passing $limit: 0. Anyway, we’ll see

Top Results From Across the Web

Renderless Data Components | FeathersVuex

The FeathersVuexFind component retrieves data from the API server, puts it in the Vuex store, then transparently retrieves the live, reactive data from...

feathers-vuex/FeathersVuexFind.ts at master - GitHub

Integration of FeathersJS, Vue, and Nuxt for the artisan developer - feathers-vuex/FeathersVuexFind.ts at master · feathersjs-ecosystem/feathers-vuex.

Renderless Data Components - FeathersVuex

These components use Vuex getters (to query data from the local store) and actions (to query data from the API server). When a...

feathers-vuex: Versions - Openbase

This fixes the useFind Vue Composition API utility. The haveLoaded property will now always be set to true when local: true is enabled...