question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

AWS Credentials for integration tests

See original GitHub issue

This is an issue to discuss having AWS Creds in the github repo.

For feature requests or changes:

Current behavior (if any)

Integration tests fail https://github.com/fernando-mc/serverless-finch/runs/5343253800?check_suite_focus=true

Proposed behavior

Added AWS Credentials to be able to run integration tests successfully

Proposed implementation details (optional)

  • @fernando-mc is hardening the credentials down so they can only perform the minimal actions needed to run the integration tests
{
    "Version": "2012-10-17",
    "Statement": [
        {
            "Sid": "AllowAllAccessToFinchTest",
            "Effect": "Allow",
            "Action": "s3:*",
            "Resource": "arn:aws:s3:::serverless-finch-test-*"
        },
        {
            "Sid": "RequiredByServerless",
            "Effect": "Allow",
            "Action": "s3:ListAllMyBuckets",
            "Resource": "*"
        }
    ]
}
  1. Add new Policy to AWS
  2. Add a new user to IAM with only programatic access and note the Key ID and Key Secret
  3. Assign the new policy to the IAM User
  4. Added the keys to this page and add them

Justification

Testing incoming changes

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:7 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
fernando-mccommented, Feb 26, 2022

You’re good on this release. Just sync with @mikejpeters at some point to figure out who is writing release notes/doc updates. As long as you don’t introduce anything else major consider it a sign off from me @Shereef! I’m out for several hours now but will be back on tonight if you need anything.

0reactions
Shereefcommented, Feb 26, 2022

This works and works well thanks @fernando-mc I have merged #144 after tests and integration tests passed

I counted my approval and @mikejpeters as the 1 approvals for each other change on the PR

next step is the release of the next version

as per your email

  1. You have sign-off from at least one of the other maintainers/collaborators before merging a PR
  2. You have sign-off from me or two other maintainers for cutting any new releases

so we need your approval or me and Mike’s to release

Read more comments on GitHub >

github_iconTop Results From Across the Web

Security Testing Your AWS Application: Part II – Integration ...
The integration tests use a real S3 client object and perform security verifications by inspecting real S3 resources, such as S3 buckets, ...
Read more >
Integration testing AWS services? : r/aws - Reddit
When we develop integration tests we set our local credentials to connect to the CI AWS account, so we can run them locally....
Read more >
Integration tests - LocalStack Docs
How to run and write integration tests. ... Login with your credentials into your AWS Sandbox Account with AWSAdministratorAccess .
Read more >
spring-attic/aws-integration-tests - GitHub
After creating the aws.credentials.properties file and storing it outside the project (or inside the project, they are ignored in git) you have to...
Read more >
Spring Boot Integration Tests With AWS Services Using ...
Setup AWS infrastructure (e.g. SQS and S3) to write integration tests for Spring applications using JUnit 5, Testcontainers and LocalStack.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found