safe-buffer in modern build tools like Vitejs

Hey, i’m trying to use ViteJs for project.

Since this is es6 only, the code errors out inside safe-buffer package Buffer is undefined here

If we included this simple check, this wouldn’t error out in ViteJs environment.

Is there any reason not to include check like this? If you would be interested, i could submit PR

[phiiil]

Adding buffer to node_modules fixed this for me.

npm i buffer

No need to change the safe-buffer package.

[JasonGore]

This should absolutely result in a change in safe-buffer package. buffer should be declared as a dep by safe-buffer in its package.json if it requires it. I found this problem when I noticed that our bundled output is using any random version of buffer it comes across installed by another dependency, regardless of buffer major versioning. This will lead to insidious and hard to troubleshoot and the dep should be declared by safe-buffer.