Infinite loop sending renegotiate: true

I think this is more a question than an actual issue. In the strange case where both peers are created with initiator: false, they will get in the loop of sending to each other a signal with {renegotiate: true}.

My question is: could/should simple peer handle this case or should it fall down to the app? Thanks.

[salwa1234]

hi, i am trying to develop a video chat application using react js and node i have used simple-peer npm package , but the problem is when i try to signal an incoming signal it is causing a loop . here is my code,

const addPeer = (data, stream) => { console.log(‘add’)

const peer = new Peer({
  initiator: false,
  trickle: false,
  stream
});

peer.on('signal', signal => {
  console.log('again')
  socket.emit("make-answer", {
    signal,
    user: user,
    to: data.senderSocket
  });
});


peer.signal(data.signal);
return peer;

};

when peer.signal fired then peer.on handler runs twice can any one help?

[t-mullen]

A connection can’t be established unless one peer is an initiator.

As for preventing an infinite loop, it should be an easy fix (non-initiators should ignore the {renegotiate: true} message. Will PR.