question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Use CDK Overlay to display the date-range-picker

See original GitHub issue

To be in line with other Angular Material components, I feel the date-range-picker should be rendered using the CDK Overlay instead of the custom position: absolute <div> we have now.

I am trying to incorporate this component in my application, but the look and feel stand out too much from other Material components for me to use it. The CDK has some wonderful features that we would get to leverage for free (positioning, Material-like UX, …), so I feel it’d be a major improvement.

I submitted a PR upgrading this repo to Angular 9 (https://github.com/fetrarij/ngx-daterangepicker-material/pull/251) to allow us to use the latest features the CDK offers, and would be willing to take a stab at changing the way this component renders.

Opinions?

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Reactions:1
  • Comments:16 (11 by maintainers)

github_iconTop GitHub Comments

2reactions
Timebuttcommented, Apr 4, 2020

That’s great news! I even fixed some issues I found in the current master while at it, plus massively improved the typing of both the directive and component. Only thing I see that still needs improvement is the fact that the code examples don’t render very well on both smaller screens and in dark mode, so I’ll see if I can finetune that.

Oh and I’ll need to rewrite/adjust some of the documentation to reflect current state of affairs. I’ll create a PR already so that you can have a look at what I’ve changed.

0reactions
Timebuttcommented, Apr 16, 2020

Closing this issue as this was resolved by merging https://github.com/fetrarij/ngx-daterangepicker-material/pull/257.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Date picker (overlay) top section is hiding due to space issue
Expected behaviour: If available space is less than automatically date picker (overlay) should shift and show full UI. Current behaviour: https ...
Read more >
Overlay problem in mat-datepicker and mat-select ... - GitHub
when you try to select an option from mat-select or a date in mat-datepicker there is an overlay in front of the page...
Read more >
How to use the @angular/cdk/overlay.OverlayConfig function ...
To help you get started, we've selected a few @angular/cdk/overlay.OverlayConfig examples, based on popular ways it is used in public projects.
Read more >
Custom Overlays with Angular's CDK - Thoughtram Blog
In this post, we'll use the CDK to build a Google Drive-like custom overlay that looks and feels much like the one built...
Read more >
Overlay Datepicker - StackBlitz
Learn how to create an overlay with Angular. Material CDK. [Demo](http://overit.estellepicq.com/). ## Table of contents. 1. [Installation](#installation).
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found