Code Quality: Update DependencyProperty generator to have the property declaration

Description

We have a problem about SourceGenerator - that is we cannot reference to the generated property in advance. Whenever I hover on the property, Visual Studio tells me there’s a error that there’s no such a property in the project because the proeprty is not declared explicitly although they will be disappeared in building.

Current:

namespace Files.App.UserControls
{
	[DependencyProperty<ToolbarViewModel>("ViewModel")]
	public sealed partial class PathBreadcrumb : UserControl
	{
		private void PathItemSeparator_DataContextChanged(FrameworkElement sender, DataContextChangedEventArgs args)
			=> ViewModel.PathItemSeparator_DataContextChanged(sender, args);
	}
}

Proposal:

namespace Files.App.UserControls
{
	public sealed partial class PathBreadcrumb : UserControl
	{
		[DependencyProperty]
		pubilc ToolbarViewModel ViewModel { get; set; }

		private void PathItemSeparator_DataContextChanged(FrameworkElement sender, DataContextChangedEventArgs args)
			=> ViewModel.PathItemSeparator_DataContextChanged(sender, args);
	}
}

Concerned code

• Files.Core.SourceGenerator

Gains

• A better readability.
• A better maintainability.

Requirements

• Update source generation way

Comments

No response

[michael-hawker]

@Poker-sang FYI we have a Toolkit Labs proposal together for this once partial properties come to .NET: https://github.com/CommunityToolkit/Labs-Windows/discussions/449

[Poker-sang]

Yes, I’m using VS2022. THat’s wierd. It should depend on .NET SDK not VS version, I suppose.

The ability to build projects depends on the .NET SDK, but the static analysis of the code (syntax highlighting) depends on the version of vs. The latest version of vs2022 (i.e. vs17.6) corresponds to roslyn version 4.6. vs2019(vs16.x) can only use the api of roslyn 3.x, while the incremental generator is a new feature of Roslyn 4.3.0 (corresponding to vs17.3). So earlier versions of vs won’t work.