question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

default transformations on 0.9

See original GitHub issue

this lib is mutating my options object with a bunch of defaults. particularly annoying is this:

transformations: {
  crop:{},
  circle: true,
  rotate: true,
}

which leaves my uploads all failing. please do not MUTATE my options object at the very least, and fix this. it even overrides if i put transformations: {}. garbage

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:6 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
velveteercommented, Aug 30, 2017

Arguments passed to client.pick should no longer be mutated in 0.9.1. Thanks again for reporting this.

0reactions
velveteercommented, Aug 25, 2017

A library mutating fn arguments isn’t a debate, it’s an anti-pattern, but I am happy to hear any reason you could come up with as a positive for a library that doesn’t produce it’s source code mutating it’s function arguments (and not documenting it).

Fair enough.

While I did not write the pick config parser, I now realize to what extent we are mutating the options passed to pick. And it extends beyond transformations. This will most certainly be changed before 1.0. Thank you for bringing this up, and for the record I share the opinion that this argument mutation is heinous, whether or not it causes bugs.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Transformations in Zeppelin Visualization
Overview · 1. PassthroughTransformation · 2. ColumnselectorTransformation · 3. PivotTransformation · 4. AdvancedTransformation. Spec; Spec: axis; Spec: sharedAxis ...
Read more >
torchvision.transforms - PyTorch
Since v0.8.0 all random transformations are using torch default random generator to sample random parameters. It is a backward compatibility breaking change ...
Read more >
Transformation — Open3D 0.9.0 documentation
The geometry types of Open3D have a number of transformation methods. In this tutorial we show how to use translate , rotate ,...
Read more >
Lesson 9: Data Transformations - STAT ONLINE
The default logarithmic transformation merely involves taking the natural logarithm — denoted l n or l o g e or simply l o...
Read more >
Cinder 0.9 Transition Guide
The vectors default construct to zero, and the matrix and quaternion variants default construct to the identity transformation.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found