Please add test cases for the sake of helping users of the library

Test caseio.finch.iteratee.EnumerateEndpointSpec does not contain any useful test case from the users’ perspective.

I’m trying to do something as simple as:

package com.example.helloworld

import cats.effect.IO
import com.twitter.finagle.Http
import com.twitter.util.Await
import io.iteratee.{Enumerator, Iteratee}
import io.finch._
import io.finch.circe._
import io.finch.iteratee._
import io.finch.catsEffect._

object Main extends App {

  def concat: Endpoint[IO, String] = post("concat" :: enumeratorBody[IO, String, Text.Plain]) {
    enum: Enumerator[IO, String] =>
      enum.into(Iteratee.fold[IO, String, String]("")(_ + _)).map(Ok)
  }

  Await.ready(
    Http.server
      .serve(":8081", (concat).toServiceAs[Text.Plain])
  )
}

with a deadly simple test case as

package com.example.helloworld

import org.scalatest.FunSuite

class MainTest extends FunSuite {
  test("helloWorld") {
    import io.finch._
    val body: String =
      """{"i":"aaaaa"}
        |{"i":"bbbbb"}
      """.stripMargin
    assert(
      Main.concat(
        Input
          .post("/concat")
          .withBody[Text.Plain](body)).awaitValueUnsafe() == Some("aaaaabbbbb"))
  }
}

and it does not work. So, it’s clear that I’m doing something wrong… but what?

Looking for test cases, there’s nothing which could provide any clue why things are going wrong.

So, please add test cases not only when things go wrong, but also showing what needs to be done in order to obtain positive results.

[vkostyukov]

@frgomes

• I filed #1040 which would ensure your server code compile (as written).
• There is #1038 that should help with testing it (would require some code changes in your test as the payload has to be chunked).
• Finally in #1018 we can add a g8 template that wires everything together

[vkostyukov]

I think we can close this. The upcoming 0.27 release has all the missing pieces outlined by this issue.