[question] Deploys to production are failing?
See original GitHub issueIām not sure if the deployments to prod are effective or not. Here we see some failures in the pipes: https://github.com/Financial-Times/polyfill-service/actions/runs/1779486094
As a consequence, this fix does not seem to be deployed in production: https://github.com/Financial-Times/useragent_parser/issues/100
As a prof of it, a request to production with a Mobile Safari 14 user-agent is still is detecting It wrongly (returning the fetch
polyfill when It should not):
curl 'https://polyfill.io/v3/polyfill.js?features=fetch' -H 'User-Agent: Mozilla/5.0 (iPhone; CPU iPhone OS 14_0_1 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/14.0 Mobile/15E148 Safari/604.1'
But a local build of the current master
seems to work fine for me:
curl 'http://localhost:8080/v3/polyfill.js?features=fetch' -H 'User-Agent: Mozilla/5.0 (iPhone; CPU iPhone OS 14_0_1 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/14.0 Mobile/15E148 Safari/604.1'
My conclusion is that master
does contain the fix and works fine, but the production host does not contain the fix, so may be the deployments to prod are really failing.
Let me know if I can help somehow. Thanks so much!
Issue Analytics
- State:
- Created 2 years ago
- Comments:6
Top GitHub Comments
@carles-thn it looks like we do have that version in the service, Iām doing some more debugging on this
@carles-thn Thanks, Iāve got enough information in the issue description - Iāll look into this now š