firestore-bigquery-export: Configuration errors for non-required values

Describe your configuration

• Extension name: firestore-bigquery-export
• Extension version: 0.1.20
• Configuration values (redact info where appropriate):

LOCATION=europe-west1
DATASET_LOCATION=europe-west1
COLLECTION_PATH=mycollection
TABLE_ID=mycollection

Describe the problem

I am using the firebase CLI to install the bigquery extension. I have a script that installs the extension for all collections that I stream into bigquery. Now I wanted to add a collection and got errors even for my collections that had the extension already installed. Usually I just get a 409 for those collection. As the parameters WILDCARD_IDS and TIME_PARTITIONING_FIELD_TYPE are not required https://github.com/firebase/extensions/blob/15d65a02fea0d98a28b163e91ef1b17c06b8615b/firestore-bigquery-export/extension.yaml#L226 , I do not understand why the installation complains that they are missing. Once I add the values to the env file

WILDCARD_IDS=false
TIME_PARTITIONING_FIELD_TYPE=omit

the installation produces the usual 409 error again, but also does not update the extension.

Steps to reproduce:

npx firebase ext:install firebase/firestore-bigquery-export --force --params params.env

Expected result

The extension updates or installs for collections where it has previously not been installed.

Actual result

The extension complains about missing config values.

⚠  undefined is not a valid option for WILDCARD_IDS.
⚠  undefined is not a valid option for TIME_PARTITIONING_FIELD_TYPE.

[joehan]

@dackers86 I think the fix here is to make these params required & keep the default values. Optional params should be valid if they are null, whereas required params should fall back to default values if they are null. It seems like the later is the desired behavior here.

Additionally, i think there is some wonkiness in how the CLI handles null values for optional SELECT params. I’ll take a look and see if i can improve the logic there a bit.

[i14h]

@dackers86 maybe this points to adding better documentation around the new features as well