question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Documentation or nullability annotation of FirebaseDynamicLinks.getDynamicLink() intent parameter wrong

See original GitHub issue

The documentation of

https://github.com/firebase/firebase-android-sdk/blob/6ccc9de98aef8a559726c04a86ab3d47b35d6eed/firebase-dynamic-links/src/main/java/com/google/firebase/dynamiclinks/FirebaseDynamicLinks.java#L102

states, that the intent parameter

can be null if the intent does not include the dynamic link. A non-null intent is necessary only when the app is launched directly using the dynamic link, such as when using App Links.

However the parameter is annotated with @NonNull. So either the documentation or the annotation is wrong and needs adaptation.

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:7 (5 by maintainers)

github_iconTop GitHub Comments

3reactions
eldhosembabucommented, Apr 28, 2021
2reactions
eldhosembabucommented, Sep 23, 2021

#2629 is merged. Expect the fix to be rolled out in upcoming releases. So closing this issue now.

Read more comments on GitHub >

github_iconTop Results From Across the Web

FirebaseDynamicLinks - Google
The intent parameter should be the intent that launched the application, or can be null if the intent does not include the dynamic...
Read more >
parameter pendingDynamicLinkData specified as non-null is ...
To fix it, you should explicitly declare that the pendingDynamicLinkData is nullable. Like this: private fun getReferralId() { Firebase.
Read more >
Firebase Dynamic Links with Xamarin Forms and .NET Backend
First, you need to create a firebase project, obviously. Then enable dynamic links. The easiest way to get started is to use the...
Read more >
com.google.firebase.dynamiclinks.FirebaseDynamicLinks
@Test public void buildDynamicLink_UriContainsCorrectComponents() throws Exception { FirebaseDynamicLinks dl = FirebaseDynamicLinks.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found