If facebook email permission is not granted, no error handling occurs

If a user does not grant the permission for the email address:

There is neither an error handling in FacebookProvider.java (the caught JSONException only closes the loading dialog):

GraphRequest request = GraphRequest.newMeRequest(
                loginResult.getAccessToken(),
                new GraphRequest.GraphJSONObjectCallback() {
                    @Override
                    public void onCompleted(JSONObject object, GraphResponse response) {
                        try {
                            String email = object.getString("email");
                            mCallbackObject.onSuccess(createIDPResponse(loginResult, email));
                        } catch (JSONException e) {
                            e.printStackTrace();
                            mCallbackObject.onFailure(new Bundle());
                        }
                    }
                });

nor an error handling in AuthMethodPickerActivity.java

    @Override
    public void onFailure(Bundle extra) {
        // stay on this screen
        mActivityHelper.dismissDialog();
    }

According to the facebook permission handling guidlines https://developers.facebook.com/docs/facebook-login/handling-declined-permissions#reprompt a reprompt should be shown. This reprompt should explain why the email permission is needed

[thrashbun]

I don’t understand the handling of this issue for Facebook. Right now the user is able to elect to not share their email address. Whether they do this or Facebook fails to return an email address anyway (because it is unverified, etc.) the user is dropped back to the Provider picker screen without being told anything failed.

As developers we have no ability to fix this at this point as we are still in the FirebaseUI activity. When the user confusedly backs out to the main activity all we can can inform them that they are still not logged in with no explanation.

In particular it is inconsistent with the way you handle emails for Twitter. On Twitter the user can also elect to keep their email private. In this case FirebaseUI works fine and registers them to the Firebase user list with a blank email address.

[melkir]

Here is my error using the last version of FirebaseUI

E> /FacebookProvider: JSON Exception reading from Facebook GraphRequest org.json.JSONException: No value for email at org.json.JSONObject.get(JSONObject.java) at org.json.JSONObject.getString(JSONObject.java) at com.firebase.ui.auth.provider.FacebookProvider$1.onCompleted(FacebookProvider.java:141) at com.facebook.GraphRequest$1.onCompleted(GraphRequest.java:304) at com.facebook.GraphRequest$5.run(GraphRequest.java:1383) at android.os.Handler.handleCallback(Handler.java:739) at android.os.Handler.dispatchMessage(Handler.java:95) at android.os.Looper.loop(Looper.java:158) at android.app.ActivityThread.main(ActivityThread.java:7229) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java)

The problem was related to this issue: http://stackoverflow.com/questions/16630972/facebook-graph-api-wont-return-email-address After updating my primary email on Facebook the problem is gone