Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Clean up test suite from 3.x.x upgrade

See original GitHub issue

As part of merging in #717 to upgrade to the Firebase 3.x.x SDK, we made a lot of testing changes and the test suite is now pretty unstable and does not pass in Travis. We need to clean things up in general and specifically focus on:

Defining a better tick() method to force the digest loop to update.
Make sure our promise chains are set up properly and that we are waiting for things properly. For example, this test does not wait for the Firebase set() to complete.
Make sure the e2e tests actually pass (e.g. the Todo app has two failing tests).

Issue Analytics

State:
Created 7 years ago
Reactions:2
Comments:5 (1 by maintainers)

Top GitHub Comments

1reaction

jwngrcommented, Jun 2, 2016

Yes, version 2.0.0 of AngularFire has been released and you can see the change log here. This bug is tracking the build failures. We wanted to get the release out instead of waiting for us to tackle all the build failures which seemed more like testing issues than actual code issues.

0reactions

jwngrcommented, Jul 11, 2016

@abehaskins - I think we can close this one now that the tests are fast and run reliably. Please re-open if there was anything else you meant to do.

Top Results From Across the Web

unittest — Unit testing framework — Python 3.11.1 ...

A test fixture represents the preparation needed to perform one or more tests, and any associated cleanup actions. This may involve, for example, ......

Java Unit Testing with JUnit and TestNG

You can perform clean-up operations by overriding tearDown() . Each test method runs on its own TestCase instance with its own set of...

googletest/primer.md at main - GitHub

In this case, TearDown() is not needed since we don't have to clean up after each test, other than what's already done by...

Testing best practices - GitLab Docs

Without careful preparation before a test runs, and cleanup afterward, a test can change data in a way that affects the behavior of...

Testing - Spring

This chapter covers Spring's support for integration testing and best practices for unit testing. The Spring team advocates test-driven ...