Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
ButtonWithPanel: add aria-expanded for a better accessibility
See original GitHub issueThe goal of this bug is to add the attribute aria-expanded to our ButtonWithPanel implementation. You can read more about this attribute on the W3C page or Marco Zehe’s blog post.
In this issue we’ll focus on aria-expanded only and not deal with aria-controls.
This should happen in https://github.com/firefox-devtools/profiler/blob/2232f077181f4ccd1c21821a8da9a94e9c53c267/src/components/shared/ButtonWithPanel/index.js#L138-L145
The attribute aria-expanded should be false when the panel is closed and true when the panel is open. Probably adding aria-expanded={String(open)} should just work.
Please take care that tests are updated (probably some snapshots will need to be updated).
Issue Analytics
- State:
- Created 3 years ago
- Comments:6 (5 by maintainers)
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
@julienw Sure, I actually saw the updated contributing.md about converting good first issues to outreachy later. It was inconvenient of me commenting in this issue. I’m sorry. I’m looking forward to contribute on other issues.
@thejozhou sorry, but it looks like the issue is resolved already. Would you mind taking another “outreachy onboarding” issue?
@maulik1729 please do not claim an issue in the future if someone else has recently claimed it already.