Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Change formatting of timestamp in Meta Info popup

See original GitHub issue

Follow up for https://github.com/devtools-html/perf.html/pull/1404#discussion_r229067443

Right now the formatting of the timestamp is bound to UTC time due to failing tests. The server has a different timezone and the screenshots fail, if we do make it local.

Greg suggested following formatting:

date.toLocaleString(navigator.language, {
  month: 'short',
  year: 'numeric',
  day: 'numeric',
  weekday: 'short',
  hour: 'numeric',
  minute: 'numeric'
})

We’d need to mock the tests here, so they do not fail. (see original comment for more info).

Issue Analytics

State:
Created 5 years ago
Comments:21 (15 by maintainers)

Top GitHub Comments

1reaction

julienwcommented, Jul 30, 2019

hey @Shubhamchinda, yes please!

The code happens in _formatDate in src/components/app/MenuButtons/MetaInfo.js. Then you’ll have to fix the tests probably using https://www.npmjs.com/package/jest-date-mock in the tests that test this functionality.

1reaction

canovacommented, Apr 2, 2019

hey @renatavmaraj, assigning it to you. Let us know if you need anything!