question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Fix the types of some of the ProfilerOverheadStats object fields

See original GitHub issue

We have a type for Overhead statistics, and all its values are Microseconds right now: https://github.com/firefox-devtools/profiler/blob/dcb8c42af81c7ee6f14c1fa5be9881dc5d03c115/src/types/profile.js#L459-L482

But some of it’s values are not actually Microseconds. For example samplingCount is just a number and overheadPercentage is a percentage. So we should fix these types to reflect the actual values. For percentage, since we don’t have a Percentage type, we need to create that type under the InnerWindowID and will look pretty similar since it’s also going to use the number esentially: https://github.com/firefox-devtools/profiler/blob/dcb8c42af81c7ee6f14c1fa5be9881dc5d03c115/src/types/profile.js#L31

After making these changes, you should make sure flow and linter is happy by running yarn flow and yarn lint-js.

Issue Analytics

  • State:open
  • Created 3 years ago
  • Comments:23 (14 by maintainers)

github_iconTop GitHub Comments

1reaction
canovacommented, Oct 20, 2020

Hi @negative0! Are you an Outreachy applicant?

If yes, great, we can assign it to you. But keep in mind that we have lots of applicants already and it might be better for you if you look for a project with less applicants at this point.

If not, sorry, but we are currently in the middle of the Outreachy contribution period and we don’t exactly have the bandwidth for contributors. But we would be more than happy if you want to contribute to the project once we are done with it. It will be done at the end of this month!

1reaction
NisaSourcecommented, Oct 8, 2020

@canova Cool, I will start working on #2810 now. Thanks

Read more comments on GitHub >

github_iconTop Results From Across the Web

Including fields in an object type - IBM
With the Profiles application permission set, select the Administration menu and click Profiles. Click the name of a profile. The Detail page opens....
Read more >
About DevTools - Codetribute - Mozilla
Project Summary Tags Console Console does not allow await in a top level block profiler Support Chrome's about:traces export format feature. help wanted. profile data Debugger...
Read more >
Manage Fields for a Specific Object - Salesforce Help
Click the field label. To modify a custom field, add custom help text, or change the data type, click Edit. If a custom...
Read more >
Types of objects and fields in Salesforce - Packt Subscription
Can't change the Grant Access Using Hierarchies sharing access ... Custom objects contain some standard field, for example, Name, Created by, Last modified ......
Read more >
Custom Field Not Showing Up Even Though it's In the Page ...
This video walks you through the settings in the custom object wizard to make sure your fields are visible to the right profiles,...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found